1
 2
 3
 4
 5
 6
 7
 8
 9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84

// ひどいコード1
var test1 = "test1";
var test2 = "test2";
var test3 = "test3";
var test4 = "test4";

// ひどいコード2
do{
	//処理
}while(false);

// ひどいコード3
while(true){

}

// ひどいコード4
// リソースのcloseなし
try {
    InputStream in = new FileInputStream(src);

    OutputStream out = new FileOutputStream(dst);
}

// ひどいコード5
// 引用元：https://qiita.com/negi111111/items/510daace637b7c57c2da
public class ClassSample {
    public static void main(String args[]) {
        int proc = 0;
        try {
            if ( proc == 0 ){
                // 正常処理
                try {
                    if ( proc == 1 ){
                        // 正常処理
                        try {
                            if ( proc == 2 ){
                                // 正常処理
                                try {
                                    if ( proc == 3 ){
                                        // 正常処理
                                        try {
                                            if ( proc == 4 ){
                                                // 正常処理
                                                if ( proc == 5 ){
                                                    // 正常処理
                                                    // まだまだ続くよ！
                                                } else {
                                                    // 異常処理
                                                }
                                            } else {
                                                // 異常処理
                                            }
                                        } catch(Exception e) {
                                            // 例外処理
                                        }
                                    } else {
                                        // 異常処理
                                    }
                                } catch(Exception e) {
                                    // 例外処理
                                }
                            } else {
                                // 異常処理
                            }
                        } catch(Exception e) {
                            // 例外処理
                        }
                    } else {
                        // 異常処理
                    }
                } catch(Exception e) {
                    // 例外処理
                }
            } else {
                // 異常処理
            }

        } catch(Exception e) {
        // 握りつぶす
        }
        System.out.println("Hello! World!");
    }
}

1
2
3
4
5
6
7

String dateString = "2016/01/01 00:00:00";
SimpleDateFormat sdf = new SimpleDateFormat("yyyy/MM/dd HH:mm:ss");
Long epochTime = sdf.parse(dateString).getTime();
System.out.println(epochTime);

// 指摘内容
// 「タイムゾーンの指定がない」

1
2
3
4

new BasicAWSCredentials(EnvProp.getAccesskey(), EnvProp.getSecretkey())));

// 指摘内容
// If possible, use temporary security credentials (IAM roles) instead of long-term access keys. Long-term access keys, such as those associated with IAM users and AWS account root users, remain valid until you manually revoke them. However, temporary security credentials obtained through IAM roles and other features of the AWS Security Token Service expire after a short period of time. Use temporary security credentials to help reduce your risk in case credentials are accidentally exposed. Learn more about best practices for managing AWS access keys.

1
2
3
4

getQueryResultsResult = amazonAthena.getQueryResults(getQueryResultsRequest);

// 指摘内容
// This code might not produce accurate results if the operation returns paginated results instead of all results. Consider adding another call to check for additional results.